Fixes handling of deferred payments (ask to buy) #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeiting
reviewed
Jul 28, 2020
| @@ -1039,7 +1039,26 @@ - (void)storeKitWrapper:(RCStoreKitWrapper *)storeKitWrapper | |||
| } | |||
| break; | |||
| } | |||
| case SKPaymentTransactionStateDeferred: | |||
| case SKPaymentTransactionStateDeferred: { | |||
aboedo
approved these changes
Jul 28, 2020
Purchases/Public/RCPurchases.m
Outdated
Comment on lines
1047
to
1051
| NSError *pendingError = [NSError errorWithDomain:RCPurchasesErrorDomain | ||
| code:RCPaymentPendingError | ||
| userInfo:@{ | ||
| NSLocalizedDescriptionKey: @"The payment is deferred." | ||
| }]; |
There was a problem hiding this comment.
maybe this should live in https://github.com/RevenueCat/purchases-ios/blob/develop/Purchases/Public/RCPurchasesErrorUtils.h
Purchases/Public/RCPurchases.m
Outdated
| pendingError, | ||
| transaction.error.code == SKErrorPaymentCancelled); | ||
| @synchronized (self) { | ||
| self.purchaseCompleteCallbacks[transaction.payment.productIdentifier] = nil; |
There was a problem hiding this comment.
I wonder if we should start checking if transaction, transaction.payment and transaction.payment.productIdentifier aren't nil before doing this. otherwise we could run into issues like ##279
On another note, we might not need to make two locks - why not unify the synchronize calls?
@synchronized (self) {
completion = self.purchaseCompleteCallbacks[transaction.payment.productIdentifier];
self.purchaseCompleteCallbacks[transaction.payment.productIdentifier] = nil;
}the block should be copied anyway, right?
There was a problem hiding this comment.
Very good point! Regarding the blocks, yes, I think we can combine the synchronized blocks
…nst transaction.payment.productIdentifier
vegaro
deleted the
cesardelavega/ch310/handle-deferred-payments-on-ios-ask-to-buy
branch
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #273
In order to test it add:
to the
SKMutablePayment. This flag will trigger aSKPaymentTransactionStateDeferred. The flow in sandbox is not the same as in production. In production, guardians get a notification with an approval request. In sandbox I have only managed to get thatSKPaymentTransactionStateDeferredtransaction.Please note that we are not finishing the transaction. The documentation is not clear, but looking at https://developer.apple.com/documentation/storekit/in-app_purchase/offering_completing_and_restoring_in-app_purchases, it looks like we only need to "Call finishTransaction(_:) on transactions whose state is SKPaymentTransactionState.failed, SKPaymentTransactionState.purchased, or SKPaymentTransactionState.restored to remove them from the queue."